Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider][base] Convert code to TypeScript #35445

Merged
merged 48 commits into from
Jan 16, 2023
Merged

[Slider][base] Convert code to TypeScript #35445

merged 48 commits into from
Jan 16, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 11, 2022 •
edited
Loading

Fixes: #34720

@sai6855 sai6855 changed the title [SliderUnstyled] Convert Slider Base to typescript [Slider][Base] Convert Slider Base to typescript Dec 11, 2022
@mui-bot
Copy link

mui-bot commented Dec 11, 2022 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-35445--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against 16a378e

@sai6855 sai6855 marked this pull request as draft December 11, 2022 18:00
@oliviertassinari oliviertassinari added component: slider This is the name of the generic UI component, not the React module! typescript labels Dec 11, 2022
mnajdova
mnajdova reviewed Dec 23, 2022
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one final comment.

packages/mui-base/src/SliderUnstyled/SliderValueLabelUnstyled.tsx Outdated Show resolved Hide resolved
@mnajdova
Copy link
Member

Make sure to update with latest master now that #35564 was merged.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 23, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 24, 2022
@sai6855 sai6855 requested review from mnajdova and ZeeshanTamboli and removed request for mnajdova December 27, 2022 04:28
@sai6855 sai6855 requested review from ZeeshanTamboli and removed request for mnajdova December 27, 2022 09:15
@ZeeshanTamboli ZeeshanTamboli changed the title [Slider][Base] Convert Slider Base to TypeScript [Slider][base] Convert code to TypeScript Dec 27, 2022
@ZeeshanTamboli ZeeshanTamboli added the package: base-ui Specific to @mui/base label Dec 29, 2022
@sai6855
Copy link
Contributor Author

sai6855 commented Jan 9, 2023 •
edited
Loading

@mnajdova can this be merged, as everything looks good?

@ZeeshanTamboli ZeeshanTamboli merged commit 2b575e2 into mui:master Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
component: slider This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Slider][base] Convert code to TypeScript
5 participants
@sai6855 @mui-bot @ZeeshanTamboli @mnajdova @oliviertassinari