Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Fix remix example #34407

Closed
wants to merge 3 commits into from
Closed

[examples] Fix remix example #34407

wants to merge 3 commits into from

Conversation

secretshardul
Copy link

The IDE complained about imports. Fixed by updated imports from remix to @remix-run/react.

@mui-bot
Copy link

mui-bot commented Sep 21, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 5d740d1

@secretshardul secretshardul changed the title [fix][examples] Update remix example imports and pin dependencies [fix][examples][doc] Fix remix imports, pin dependencies and add link to example Sep 21, 2022
@secretshardul secretshardul mentioned this pull request Sep 21, 2022
Closed
1 task
@secretshardul secretshardul mentioned this pull request Sep 21, 2022
Closed
@oliviertassinari oliviertassinari added the examples Relating to /examples label Sep 21, 2022
@oliviertassinari oliviertassinari changed the title [fix][examples][doc] Fix remix imports, pin dependencies and add link to example [examples] Fix remix example Sep 21, 2022
@secretshardul
fix: Unpin remix example dependencies, update docs and lint
5d740d1 
- Use 'latest' dependencies in Remix example
- Add remix example in Portuguese and Chinese docs
- Examples point to master instead of HEAD
- Remove spacing as per convention
@secretshardul
Copy link
Author

Made the changes

@secretshardul
Copy link
Author

@oliviertassinari can we use your example in Remix's github repo?

remix-run/examples#9 (review)

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 21, 2022 •
edited by mnajdova
Loading

I don't think that we need our permission. However, for a recommendation, I think that https://github.com/vercel/next.js/tree/canary/examples/with-material-ui's pattern would be better, to avoid the dilution of the effort.

@mnajdova mnajdova mentioned this pull request Sep 23, 2022
Open
@mnajdova
Copy link
Member

I don't think that we need our permission. However, for a recommendation, I think that https://github.com/vercel/next.js/tree/canary/examples/with-material-ui's pattern would be better, to avoid the dilution of the effort.

Agree, I don't think it's worth maintaining examples in two places. For example based on #34170 seems like our example is already outdated, and haven't to check this in two places would add unnecessary burden. Maybe just linking this example would be sufficient.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 24, 2022
@phoenixcoded20
Copy link

This seems to be a still valid PR to be merged. Any update on this?

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Apr 13, 2023 •
edited
Loading

This seems to be a still valid PR to be merged. Any update on this?

@phoenixcoded20 Would you like to continue working on this PR? I guess there are some changes left.

There are multiple issues regarding Remix's example - https://github.com/mui/material-ui/issues?q=is%3Aissue+is%3Aopen+remix+label%3Aexamples. Anybody who is willing to work on them, can collaborate on this PR or feel free to create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

Assignees
No one assigned
Labels
examples Relating to /examples PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@secretshardul @mui-bot @oliviertassinari @mnajdova @phoenixcoded20 @ZeeshanTamboli