Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] Move from e to event #3398

Merged
merged 1 commit into from
Feb 21, 2016
Merged

[eslint] Move from e to event #3398

merged 1 commit into from
Feb 21, 2016

Conversation

oliviertassinari
Copy link
Member

This one is for me 💫. The event name has far more meaning than a single letter e.
For instance, have a look at the React documentation https://facebook.github.io/react/docs/forms.html.

I will take care of react/jsx-handler-names once this PR is merged.

@alitaheri
Copy link
Member

This must be the happiest day of your life 😆 😆 Looks really good 👍 Thanks a lot 😁

@mbrookes
Copy link
Member

All clean and green, notwithstanding npm WARN [email protected] requires a peer of eslint@^1.6.0 but none was installed.

@oliviertassinari
Copy link
Member Author

This must be the happiest day of your life

We are close to it 🚀.

Hum, that's weird. Let's merge this before I get any conflict 😁

oliviertassinari added a commit that referenced this pull request Feb 21, 2016
@oliviertassinari oliviertassinari merged commit 163eb57 into mui:master Feb 21, 2016
@oliviertassinari oliviertassinari deleted the eslint-id-blacklist branch February 21, 2016 08:56
@mbrookes
Copy link
Member

npm WARN [email protected] requires a peer of eslint@^1.6.0 but none was installed

num update && npm install hadn't helped, but deleting node_modules and reinstalling made that go away.

@zannager zannager added package: system Specific to @mui/system package: eslint Specific to eslint-plugin-material-ui labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: eslint Specific to eslint-plugin-material-ui package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants