v5.10.1 #33933
Merged
v5.10.1 #33933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mnajdova
commented
Aug 15, 2022
mnajdova
commented
- I have followed (at least) the PR section of the contributing guide.
mnajdova
commented
Aug 15, 2022
| @@ -57,9 +57,9 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.17.2", | |||
| "@mui/base": "5.0.0-alpha.92", | |||
| "@mui/core-internal-download-tracker": "5.10.0", | |||
There was a problem hiding this comment.
@michaldudak was it intentional that you didn't use "^" here?
There was a problem hiding this comment.
I don't think it matters in this case - we'll always release new versions of the tracker, Material UI, and Joy together so that they will be updated together. Having ^ wouldn't change much, unless I'm missing something.
There was a problem hiding this comment.
Let's use "^" to be consistent with the other packages.
michaldudak
reviewed
Aug 16, 2022
Co-authored-by: Michał Dudak <[email protected]>
michaldudak
approved these changes
Aug 16, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.