-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TableCell] Enable size prop overrides via module augmentation #33816
[TableCell] Enable size prop overrides via module augmentation #33816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for your first contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update the size
prop type in TableCell
. Here is an example of how it should be:
material-ui/packages/mui-material/src/Table/Table.js
Lines 118 to 121 in a804ca8
size: PropTypes /* @typescript-to-proptypes-ignore */.oneOfType([ | |
PropTypes.oneOf(['medium', 'small']), | |
PropTypes.string, | |
]), |
Then update the API docs.
Enable TableCell size prop overrides via module augmentation using pattern recommend in #33802 (comment).
Fixes #33802