Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.9.2 #33640

Merged
merged 8 commits into from
Jul 25, 2022
Merged

v5.9.2 #33640

merged 8 commits into from
Jul 25, 2022

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Jul 25, 2022

@hbjORbj hbjORbj added the release We are shipping :D label Jul 25, 2022
@hbjORbj hbjORbj requested a review from a team July 25, 2022 11:19
@mui-bot
Copy link

mui-bot commented Jul 25, 2022

No bundle size changes

Generated by 🚫 dangerJS against bf36b8c

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
### Core

- &#8203;<!-- 06 -->[test] Remove `view` option from Event in Snackbar tests (#33555) @ZeeshanTamboli
- &#8203;<!-- 05 -->[website] Update home page's sponsor grid (#33528) @danilo-leal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to put [website] tag under both Docs and Core sections. We should decide on one @mui/core

Copy link
Member

@mnajdova mnajdova Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All [website] tags should go under Docs, I haven't seen cases where it should be under core. I would say this should be moved to Docs.

At least this is what we were doing so far.

Copy link
Member

@oliviertassinari oliviertassinari Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I think that the developers using the library, looking for information on the changelog that might benefit them, so shouldn't care about what happens on the website or the blog, so I would imagine that it by going under ### Core (the infrastructure work that supports the product) It would help bury these changes a bit more at the bottom of the changelog. But maybe for the blog posts, it's actually relevant, so should be under Docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that website-tagged commits have been under Docs sometimes or Core sometimes. Which column should we stick with? Core makes more sense to me since it's more internal work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will go ahead and release for now. The website-tagged commits are under Docs in this PR.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari removed their request for review July 25, 2022 13:26
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me Benny.

@hbjORbj hbjORbj merged commit b7f0a16 into mui:master Jul 25, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants