-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v5.9.2 #33640
v5.9.2 #33640
Conversation
hbjORbj
commented
Jul 25, 2022
- I have followed (at least) the PR section of the contributing guide.
### Core | ||
|
||
- ​<!-- 06 -->[test] Remove `view` option from Event in Snackbar tests (#33555) @ZeeshanTamboli | ||
- ​<!-- 05 -->[website] Update home page's sponsor grid (#33528) @danilo-leal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to put [website] tag under both Docs and Core sections. We should decide on one @mui/core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All [website] tags should go under Docs, I haven't seen cases where it should be under core. I would say this should be moved to Docs.
At least this is what we were doing so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I think that the developers using the library, looking for information on the changelog that might benefit them, so shouldn't care about what happens on the website or the blog, so I would imagine that it by going under ### Core
(the infrastructure work that supports the product) It would help bury these changes a bit more at the bottom of the changelog. But maybe for the blog posts, it's actually relevant, so should be under Docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that website-tagged commits have been under Docs sometimes or Core sometimes. Which column should we stick with? Core makes more sense to me since it's more internal work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will go ahead and release for now. The website-tagged commits are under Docs in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me Benny.