Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Fix display on Safari #33102

Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 10, 2022

I was checking https://twitter.com/constlomo/status/1535066785183301632 out quickly. Before I could start any exploration, I was immediately stopped by:

Screenshot 2022-06-11 at 01 13 44

Otherwise, I couldn't reproduce this tweet on iOS v15.4 in the Simulator nor BrowserStack.

In the US, iOS is almost 60% of the market, on which, all browsers are using Safari under the hood, Chrome included proof: https://gs.statcounter.com/os-market-share/mobile/united-states-of-america, hence most people will notice since blog posts are read a lot on mobile (could be tested in GA).

https://deploy-preview-33102--material-ui.netlify.app/blog/

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work blog labels Jun 10, 2022
@mui-bot
Copy link

mui-bot commented Jun 10, 2022

No bundle size changes

Generated by 🚫 dangerJS against 25197e0

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@oliviertassinari oliviertassinari merged commit f0f8acc into mui:master Jun 14, 2022
@oliviertassinari oliviertassinari deleted the fix-blog-safari-display branch June 14, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants