[EnhancedTextArea] add shadowStyle #3274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alitaheri
added
the
PR: needs revision
cgestes
changed the title
(in my case to allow applying box-sizing)
|
will wait till #3252 is merged. |
|
Or that 😆 😆 |
|
Should we mirror the style of the textarea and just override the important properties instead? Otherwize the shadow has to be adjusted by hand which is very error prone |
|
too much related commits. making only one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(in my case to allow applying box-sizing)
Also added border: 'none' to make it more like the visible one. (2 pixels does not change a lot... but you never know)