Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpeedDialAction] Add support for CSS variables #32608

Merged
merged 3 commits into from
Jun 17, 2022
Merged

[SpeedDialAction] Add support for CSS variables #32608

merged 3 commits into from
Jun 17, 2022

Conversation

gin1314
Copy link
Contributor

@gin1314 gin1314 commented May 4, 2022 •
edited
Loading

@vicasas vicasas added new feature New feature or request component: speed dial This is the name of the generic UI component, not the React module! labels May 4, 2022
@vicasas vicasas mentioned this pull request May 4, 2022
Closed
65 tasks
@siriwatknp siriwatknp added the on hold There is a blocker, we need to wait label May 5, 2022
@siriwatknp
Copy link
Member

I found this in SpeedDialAction.js:

'&:hover': {
  backgroundColor: emphasize(theme.palette.background.paper, 0.15),
},

@gin1314
Copy link
Contributor Author

gin1314 commented May 5, 2022

Yes, I made no changes on that line

@siriwatknp siriwatknp mentioned this pull request May 20, 2022
Merged
1 task
siriwatknp
siriwatknp approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for your contribution! good to go.

@mui-bot
Copy link

mui-bot commented Jun 17, 2022 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against f9dd2fc

@siriwatknp siriwatknp removed the on hold There is a blocker, we need to wait label Jun 17, 2022
@siriwatknp siriwatknp merged commit f043f3a into mui:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
component: speed dial This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gin1314 @siriwatknp @mui-bot @vicasas