Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImageListItemBar] Add support for CSS variables #32578

Merged
merged 1 commit into from
May 4, 2022

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented May 3, 2022

@vicasas vicasas added new feature New feature or request component: image list This is the name of the generic UI component, not the React module! labels May 3, 2022
@vicasas vicasas requested review from mnajdova and siriwatknp May 3, 2022 12:25
@mui-bot
Copy link

mui-bot commented May 3, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 6e0b987

@mnajdova
Copy link
Member

mnajdova commented May 3, 2022

Seeing

fontFamily: theme.typography.fontFamily,
I am starting to think that maybe we should not skip the whole typography when generating the CSS vars. cc @siriwatknp

Let's resolve this @vicasas, the rest looks good 👍

@vicasas
Copy link
Member Author

vicasas commented May 3, 2022

Let's resolve this @vicasas, the rest looks good 👍

For this I would have to modify the theme to add support for typography? Why when changing it dry this throws an error #32049 (comment).

After this, would we also include the typography in all other components?

@vicasas vicasas changed the title [ImageList] Add support for CSS variables [ImageListItemBar] Add support for CSS variables May 3, 2022
@mnajdova
Copy link
Member

mnajdova commented May 4, 2022

Ah, I haven't seen that @siriwatknp already commented to left it now for now in #32049 (comment)

Ok, sorry about this, let's merge this one and come back to the typography in a dedicated PR where we will update it in all components.

@mnajdova
Copy link
Member

mnajdova commented May 4, 2022

After this, would we also include the font in all other components?

Yes, if we decide to generate some of the vars, we would update it in all components

@siriwatknp siriwatknp merged commit f7cb3b9 into mui:master May 4, 2022
@vicasas
Copy link
Member Author

vicasas commented May 4, 2022

Yes, if we decide to generate some of the vars, we would update it in all components

Perfect, it seems good to me.

@vicasas vicasas deleted the image-list-item-bar-css-vars branch May 4, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: image list This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants