[Fab] Add support for CSS variables #32564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
component: Fab
65 tasks
siriwatknp
reviewed
May 4, 2022
Comment on lines
+58
to
+59
| color: theme.vars | ||
| ? theme.vars.palette.text.primary |
There was a problem hiding this comment.
This looks good to me because getContrastText(grey[300]) 99.99% returns text.primary. cc @mnajdova
There was a problem hiding this comment.
leaves 0.01% for the super edge case where custom grey[300] has high contrast.
There was a problem hiding this comment.
Sounds good 👍 We will see if people complain (I don't expect it will happen :))
alisasanib
changed the title
mnajdova
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one of #32049
Preview: https://deploy-preview-32564--material-ui.netlify.app/experiments/material-ui/fab/
cc: @mui/contributors