[Avatar] Remove style-propable mixin #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
90 tasks
| } = state.muiTheme; | ||
|
|
||
| const styles = { | ||
| root: Object.assign({ |
There was a problem hiding this comment.
This is a ternary vampire, sucking the life out of readability 😆 😆
root: {
color,
backgroundColor,
userSelect: 'none',
display: 'inline-block',
textAlign: 'center',
lineHeight: `${size}px`,
fontSize: size / 2 + 4,
borderRadius: '50%',
border: src ? `solid 1px ${avatar.borderColor}` : undefined,
height: src ? size - 2 : size,
width: src ? size - 2 : size,
},There was a problem hiding this comment.
Haha, thank you for your patience with me, good sir. 😆
There was a problem hiding this comment.
no worries, programming is a playful job. It always tickles you to write clever code. We've all been there 😆 😆
newoga
added
PR: needs revision
|
newoga
added
PR: Needs Review
and removed
PR: needs revision
|
All good 👍 👍 |
|
|
||
| if (borderColor) { |
There was a problem hiding this comment.
Could you add this logic back 😁?
I'm using the muiTheme like this:
avatar: {
borderColor: null,
},There was a problem hiding this comment.
Oh good catch, I don't know how I missed that borderColor was part of the condition for applying those styles. Thanks!
|
|
@newoga Thanks! It's time to sleep 😴. |
oliviertassinari
added a commit
that referenced
this pull request
Feb 8, 2016
[Avatar] Remove style-propable mixin
Haha, thanks! |
zannager
added
the
component: avatar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.