[Toggle] Remove style-propable mixin

[newoga]

No description provided.

[oliviertassinari]

@newoga That looks good 👍.

[newoga]

@oliviertassinari I'm done with this, should we merge, get another pair of eyes to take a look?

[alitaheri]

👍 It's all good.

[oliviertassinari]

Don't worry too much about the let/const. One month ago, I have tried to implement a fix function for the eslint rule. It was almost working. We can almost automate this.

[newoga]

Awesome! That's good to know, I definitely support whenever we can reliably automate something 👍

[oliviertassinari]

Actually, the pain points are those ones:

    let {
      anchorOrigin,
      className,
      iconButtonElement,
      iconStyle,
      onItemTouchTap,
      onKeyboardFocus,
      onMouseDown,
      onMouseLeave,
      onMouseEnter,
      onMouseUp,
      onTouchTap,
      menuStyle,
      style,
      targetOrigin,
      ...other,
    } = this.props;

When one of the previous variables is used as a let, I can't use const at the top.

[newoga]

Yeah I think I noticed this too when I was doing it. If I remember correctly it was iconButtonElement that could possibly be reassigned. If we pass the elements that get passed in as props to a stateless internal component, that could handle the logic and we could probably make all of these const then.

Though that process would be tough to automate.

[oliviertassinari]

@newoga Thanks! You are a beast 🐻.

[newoga]

Thanks! 😄