[TimePicker] Remove style-propable mixin

[newoga]

No description provided.

[oliviertassinari]

nextContext.muiTheme || this.state.muiTheme?
But that's a minor point.

[newoga]

True, I like that more. I'll switch to that since I'm going through.

[oliviertassinari]

@newoga That loos good 👍.

[newoga]

Mm, not sure why this build failed. Timing issue maybe, I ran the tests locally again newoga@0e2b22f and can't reproduce the fail.

[mbrookes]

I've seen that on another PR. Make a trivial change and push to force a re-run. Or we just ignore the error.

[newoga]

I've seen that on another PR. Make a trivial change and push to force a re-run. Or we just ignore the error.

Interesting, okay thanks @mbrookes!

[newoga]

Done, switch the setState to use nextContext.muiTheme || this.state.muiTheme.

[alitaheri]

I've seen that on another PR. Make a trivial change and push to force a re-run. Or we just ignore the error.

Also, those with push access to the repository can login to the travis-ci (with their github account) and manually restart the build. It's cleaner and faster.

[alitaheri]

any reason why these are instantiating with each render? I don't see any.

[oliviertassinari]

Wow, indeed 😨.

[alitaheri]

This is some hard work 👍 👍 Although I'm ok with merging this as it is. we'll probably change the way we calculate the styles soon after we figure out how we should implement memoization.

[oliviertassinari]

I agree, let's do one thing at the time.
@newoga Thanks for your hard work!

[alitaheri]

🎉 🎈 🎉 awesome work @newoga 👍

[newoga]

Thanks guys! 🎉
Yeah as I've been going through many of the components, I'm see a lot of areas that could use improvement (esp as it relates to performance). Though I will try to stay focused and keep changes related to migration of mixin to context.