[Core] Remove controllable.js mixin #2889
Conversation
…ethods The `mixins/controllable.js` mixin adds a `getValueLink()` method to components and is currently used in two places: - Menu - Tabs This commit moves the function locally into each of the components so that they don't depend on the `controllable.js` mixin. The functions should be removed when we're ready to officially deprecate valueLinks.
|
Related to #2880 @oliviertassinari If we're ready to start the "deprecating valueLink" effort now, let me know and I can see if I can refactor the |
|
@alitaheri Feel free to review this at your convenience too. Just trying to remove the "low hanging fruit" mixins 😄 |
|
@newoga Thanks 😁 Are these imperative methods even used anywhere? They aren't documented anyway. think we can remove them entirely?
|
|
@alitaheri Yeah I agree, I didn't see them used anywhere except inside the components. I moved the method over as is just so it would work exactly as it did before. The method is called quite a few times internally. I think the best time to remove would be when we start conceptually deprecating the |
|
@newoga No need. But I think it wouldn't hurt to add a comment explicitly stating that we will remove them so no one would rely on them until then // Remove with valueLink? |
|
@alitaheri Good idea, I'll add a comment for now 👍 |
|
@newoga Thank you ( ^_^ ) |
That's a very good step.
Well, I think that we can start working on it 👍. |
[Core] Remove controllable.js mixin
This PR removes
mixins/controllableand replaces functionality with local methods.The
mixins/controllable.jsmixin adds agetValueLink()method to components and is currently used in two places:MenuTabsThis commit moves the function locally into each of the components so that they don't depend on the
controllable.jsmixin. The functions should be removed when we're ready to officially deprecate valueLinks.