[test] Update tests to pass react@next #26967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Jun 26, 2021
Comment on lines
-258
to
-259
| !React.version.startsWith('18') && | ||
| "Error: Uncaught [TypeError: Cannot read property 'removeAttribute' of null]", |
There was a problem hiding this comment.
This was actually a bug reported in facebook/react#21712
eps1lon
force-pushed
the
test/react-next-update
branch
from
bed587c
to
c879124
Compare
package.json
Outdated
Comment on lines
203
to
206
| "react-dom": "18.0.0-alpha-73ffce1b6-20210624", | ||
| "react-test-renderer": "18.0.0-alpha-73ffce1b6-20210624", | ||
| "react-is": "18.0.0-alpha-73ffce1b6-20210624", | ||
| "react": "18.0.0-alpha-73ffce1b6-20210624" |
There was a problem hiding this comment.
Is this change intended? Does it mean we run the whole project with React 18 with this in?
This reverts commit fb5f149.
eps1lon
force-pushed
the
test/react-next-update
branch
from
37f14fd
to
9d84a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://app.circleci.com/pipelines/github/mui-org/material-ui/47918/workflows/902ddf28-bee1-497c-bb24-285f5231f1db/jobs/268916