-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Timeline] Add support for position override on items #25974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/material-ui-lab/src/TimelineOppositeContent/TimelineOppositeContent.test.js
Outdated
Show resolved
Hide resolved
oliviertassinari
added
the
component: timeline
This is the name of the generic UI component, not the React module!
label
Apr 25, 2021
oliviertassinari
changed the title
[Timeline] Add support for align override on items #25862
[Timeline] Add support for align override on items
Apr 25, 2021
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 28, 2021
…me "RightAlignedTimeline" to "LeftPositionedTimeline"
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Apr 28, 2021
mnajdova
changed the title
[Timeline] Add support for align override on items
[Timeline] Add support for position override on items
Apr 28, 2021
mnajdova
reviewed
Apr 28, 2021
packages/material-ui-lab/src/TimelineContent/TimelineContent.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Marija Najdova <[email protected]>
Co-authored-by: Marija Najdova <[email protected]>
mnajdova
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
eps1lon
pushed a commit
to siriwatknp/material-ui
that referenced
this pull request
Apr 29, 2021
siriwatknp
added a commit
that referenced
this pull request
May 12, 2021
* migrate to emotion * make styleProps optional * remove lint and add fn name * use yearButton from styles * revert types * [docs] Document all the colors available (#26015) * [Timeline] Add support for position override on items (#25974) * [core] Remove deprecated innerRef prop (#26028) [core] Remove deprecated innerRef prop (#26028) * [theme] Rename `createMuiTheme` to `createTheme` (#25992) * [pickers] Remove redundant aria-hidden (#26014) * [internal][pickers] Remove unused styles (#26023) * [pickers] Toggle mobile keyboard view in the same commit as the view changes (#26017) * [DateRangePicker] Fix not being opened on click (#26016) * Inline classes * type -> interface * sort asc * default props are private * remove uneccesary type casting * follow convention * trigger pipeline Co-authored-by: Anshuman Pandey <[email protected]> Co-authored-by: simonecervini <[email protected]> Co-authored-by: Matheus Wichman <[email protected]> Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: timeline
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
[Timeline] Rename the
align
prop toposition
to reduce confusion.A proof of concept of the proposed solution from #25862
Closes #25862
Preview: https://deploy-preview-25974--material-ui.netlify.app/components/timeline/#left-positioned-timeline