Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timeline] Migrate TimelineItem to emotion #25822

Merged
merged 8 commits into from
Apr 19, 2021
Merged

[Timeline] Migrate TimelineItem to emotion #25822

merged 8 commits into from
Apr 19, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Apr 18, 2021

One of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 18, 2021 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against eae4428

@oliviertassinari oliviertassinari added the component: timeline This is the name of the generic UI component, not the React module! label Apr 18, 2021
@siriwatknp siriwatknp mentioned this pull request Apr 19, 2021
Closed
mnajdova
mnajdova reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cleanup needed with the context, otherwise looks good.

packages/material-ui-lab/src/TimelineItem/TimelineItem.js Outdated Show resolved Hide resolved
packages/material-ui-lab/src/TimelineItem/TimelineItem.js Outdated Show resolved Hide resolved
packages/material-ui-lab/src/TimelineItem/TimelineItem.js Outdated Show resolved Hide resolved
@mnajdova mnajdova mentioned this pull request Apr 19, 2021
Merged
1 task
@vicasas
Copy link
Member Author

vicasas commented Apr 19, 2021

I will review this later.

mnajdova
mnajdova approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've done some cleanup on the context as we don't need it anymore, otherwise it looked good.

@mnajdova mnajdova merged commit 521e5a8 into mui:next Apr 19, 2021
@vicasas
Copy link
Member Author

vicasas commented Apr 19, 2021 •
edited
Loading

I think i'm late 😆. Thank you as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: timeline This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vicasas @mui-pr-bot @oliviertassinari @mnajdova