[docs] Batch small fixes #25807
Merged
[docs] Batch small fixes #25807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4theushw
commented
Apr 17, 2021
docs/src/pages/components/breadcrumbs/CustomizedBreadcrumbs.tsx
Outdated
Show resolved
Hide resolved
oliviertassinari
requested changes
Apr 17, 2021
docs/src/pages/components/breadcrumbs/CustomizedBreadcrumbs.tsx
Outdated
Show resolved
Hide resolved
m4theushw
commented
Apr 20, 2021
Comment on lines
30
to
31
| {/* https://github.com/emotion-js/emotion/issues/2158#issuecomment-761817004 */} | ||
| <CssBaseline /> |
There was a problem hiding this comment.
I would personally vote against this change because it forces CssBaseline on all the pages of the documentation. So far, we had tried to share the minimum amount of setup possible between the pages. I think that this one would be going to far. For instance, say you want to use an empty page to reproduce a bug, you don't want to see the global CSS resets.
I think that it would be best to wait for @mnajdova to solve this issue inside emotion.
There was a problem hiding this comment.
Please revert, this is getting fixed at the root in #25690
oliviertassinari
approved these changes
Apr 23, 2021
|
@m4theushw great polish 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-25807--material-ui.netlify.app/
I opened this PR to fix some small things I found while navigating the docs using the dark mode. In each change there's a screenshot showing the current situation.