[DatePicker] data-picker-inline Popover instead of Paper

[tyfoo]

#2120 (comment)

[oliviertassinari]

Could you add onRequestClose as a required value in the propTypes definition?
This is what makes the clickaway feature work. I think that it's better to be explicit.

The Popover is not correctly positioned when opened.
It seems that we have an issue with the anchorEl property.
@chrismcv any tips?

[oliviertassinari]

Can you put the {...other} at the beginning? I think that it's better in general, you don't want specific properties to be overridden.

[chrismcv]

Only thing I can think of is that the ref won't exist on the first render, so if that happens to be the only render, then you're effectively passing null to the anchorEl prop.

[oliviertassinari]

Only thing I can think of is that the ref won't exist on the first render, so if that happens to be the only render, then you're effectively passing null to the anchorEl prop.

That's true. However, when the popover is opened and rerendered, the ref is valid, still the position is wrong.
Could this is because of a wrong update of the ref position?

[tyfoo]

@oliviertassinari I've moved {...others} to the beginning.

In regards to onRequestClose, where would you like me to add it? the date-picker-inline shouldn't be used directly? I can add onRequestClose as required for DatePicker and then pass it down?

I've noticed that Popover already has a default onRequestClose and that ClickAway seems to work as is.

[chrismcv]

you'll need it, as if the state is reset externally then open prop could be wrong. Specifically, the inline date picker should handle onRequestClose to manage this open state.