Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SelectField][TextField] Fix error styling issue #2539

Merged
merged 2 commits into from
Dec 16, 2015
Merged

[SelectField][TextField] Fix error styling issue #2539

merged 2 commits into from
Dec 16, 2015

Conversation

oliviertassinari
Copy link
Member

Fix #2532 and #2486.
Improved version of this PR #2534.

I have added some examples for the SelectField with the errorText property.
@subjectix I have also made the imperative setErrorText() and setValue() method deprecated.

@alitaheri
Copy link
Member

@oliviertassinari This is good for now. patches up an ugly bug. but we'll need some major rewrite for these components. there are so many styling issues affecting them. For one, when the error appears it shouldn't take up more space, but rather reserve it's space (or some props should do that.). Implementing #2416 will make all our problems go away :D

@oliviertassinari
Copy link
Member Author

@subjectix I have rebase to solve the conflict.

For one, when the error appears it shouldn't take up more space.

I'm not convinced by this, the errorText is not always here and can have an arbitrary height.

@alitaheri
Copy link
Member

@oliviertassinari You have a point. But I've seen people having issues with this. when forms are prone to validation errors, some people would like to keep the spacing intact. I think we should implement the proposal in #2416 and add many options to for error text to support this use-case.

@alitaheri
Copy link
Member

I'm merging this fix for now. Thanks @oliviertassinari
We have to discuss that further and it has nothing to do with this PR.

alitaheri added a commit that referenced this pull request Dec 16, 2015
[SelectField][TextField] Fix error styling issue
@alitaheri alitaheri merged commit e8b29ea into mui:master Dec 16, 2015
@oliviertassinari oliviertassinari deleted the field-fix-error branch December 16, 2015 09:32
@pulse00
Copy link

pulse00 commented Jun 2, 2016

Spacing of SelectFields with floating label is still an issues in 0.15 (see screenshot).
As soon as an item is selected an the floating label goes up, the text-field borders are aligned horizontally again.

screen shot 2016-06-02 at 18 48 02

@zannager zannager added the component: text field This is the name of the generic UI component, not the React module! label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SelectField with floatingLabelText and errorText
4 participants