Fix selectable=false still selects rows #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The select row function was still called for selectable=false. This patch fixes that.
|
Thanks a lot, such a nasty bug 😨 |
alitaheri
added a commit
that referenced
this pull request
Dec 13, 2015
Fix selectable=false still selects rows
This was referenced May 8, 2020
This was referenced Jul 8, 2020
This was referenced Mar 13, 2022
zannager
added
the
component: select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The select row function was still called for selectable=false. This patch fixes that.
A possible alternative is to put this check in onCellClick and not calling onRowClick if selectable is false. I'm not sure what you'd prefer but this works for me.
Fixes #2176