-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hidden] Migrate to emotion #24544
[Hidden] Migrate to emotion #24544
Conversation
@material-ui/core: parsed: +0.12% , gzip: +0.13% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a first round of review. Will do another one after these comments are resolved :)
ff2c8fe
to
7366a0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we needed to migrate it as we want to remove the components but it looks great :)
This PR migrates the
Hidden
component (specifically,HiddenCss
) to the new emotion format as a part of #24405.This component was very complex. I'm hoping I pulled it off properly!