Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't need any code changes to fix it. I'm leaving the change to vercel in regardless to get a feel of how much slower exporting every locale is. Actual analysis of the issue below.
production deploys are currently failing for
next
(e.g. https://app.netlify.com/sites/material-ui/deploys/5fd31f0b071ca50007de7b01). Opening to notify that we're aware of the issue.post-mortem
Broken when merging #23745. Shortly after it another PR was merged skipping the netlify deploy so https://app.netlify.com/sites/material-ui/deploys/5fd2552ee192c200082e8622 is the first one failing even though it's unrelated.
Figuring out:
Looks like a caching issue. Notice how on https://app.netlify.com/sites/material-ui/deploys/5fd31f0b071ca50007de7b01 we fail with a cache hit. However, https://app.netlify.com/sites/material-ui/deploys/5fd39c682427ad0c51e57510 is passing with a cache miss (I re-deployed with a cleared cache). The failing pages got introduced on a skipped build. This comes down to nextjs caching things like the page and routes manifest. However, the cache key for those is the yarn.lock file so we could have a cache hit even though pages changed.
I'm not sure whether netlify should never skip on
next
or if nextjs should re-generate those files all the time. If nextjs actually caches these manifests that aggressively then we should get build failures everytime we change pages. That should be a frequent problem but consideringnext export
is an "advanced use case" it might be a rare bug for them.