Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix production deploy #23963

Merged
merged 1 commit into from
Dec 11, 2020
Merged

[docs] Fix production deploy #23963

merged 1 commit into from
Dec 11, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 11, 2020

Didn't need any code changes to fix it. I'm leaving the change to vercel in regardless to get a feel of how much slower exporting every locale is. Actual analysis of the issue below.

production deploys are currently failing for next (e.g. https://app.netlify.com/sites/material-ui/deploys/5fd31f0b071ca50007de7b01). Opening to notify that we're aware of the issue.

post-mortem

Broken when merging #23745. Shortly after it another PR was merged skipping the netlify deploy so https://app.netlify.com/sites/material-ui/deploys/5fd2552ee192c200082e8622 is the first one failing even though it's unrelated.

Figuring out:

  1. why is it not failing on PRs even though it fails with the english locale
  2. Netlify only issue?

Looks like a caching issue. Notice how on https://app.netlify.com/sites/material-ui/deploys/5fd31f0b071ca50007de7b01 we fail with a cache hit. However, https://app.netlify.com/sites/material-ui/deploys/5fd39c682427ad0c51e57510 is passing with a cache miss (I re-deployed with a cleared cache). The failing pages got introduced on a skipped build. This comes down to nextjs caching things like the page and routes manifest. However, the cache key for those is the yarn.lock file so we could have a cache hit even though pages changed.

I'm not sure whether netlify should never skip on next or if nextjs should re-generate those files all the time. If nextjs actually caches these manifests that aggressively then we should get build failures everytime we change pages. That should be a frequent problem but considering next export is an "advanced use case" it might be a rare bug for them.

@eps1lon eps1lon added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Dec 11, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 11, 2020

No bundle size changes

Generated by 🚫 dangerJS against ad384d9

@eps1lon eps1lon marked this pull request as ready for review December 11, 2020 16:43
@eps1lon eps1lon removed the bug 🐛 Something doesn't work label Dec 11, 2020
@eps1lon eps1lon merged commit 4939060 into mui:next Dec 11, 2020
@eps1lon eps1lon deleted the docs/fix-prod-deploy branch December 11, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants