[LeftNav] Rename onChangeRequest to onRequestChange #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to make the property name coherent with the `Dialog` component. In the `²Dialog` component we have an `onRequestClose` property
|
Yes absolutely 👍 👍 |
oliviertassinari
added a commit
that referenced
this pull request
Dec 3, 2015
…t-change [LeftNav] Rename onChangeRequest to onRequestChange
This was referenced Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to make the property name coherent with the
Dialogcomponent.In the
Dialogcomponent we have anonRequestCloseproperty.@subjectix Are you ok with this change?