-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Remove debug
in favor of open
and dev tools
#23377
Conversation
The prop is most often used to customize the rendering of the popup, the CSS, or the elements themselves. During such a session, the solution needs to support fast refresh and likely hard reload. I would be cautious with a React dev-tools or a Chrome Devtool only solution because it has a short lifespan. One downside of the |
Set
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah ok, I will use open
in the future. Great alternative! I originally got the idea from https://docsearch.algolia.com/docs/styling/#debugging.
I have added a diff for the next release changelog in the PR's description. What do you think about it? Could we include something in the v5 migration guide?
2053f2a
to
8815e90
Compare
debug
in favor of react-devtoolsdebug
in favor of open
and dev tools
Breaking changes
debug
propThere are a couple of simpler alternatives:
open={true}
, Chrome devtools "Emulate focused", or React devtools props.With recent react-devtools updates editing props is fairly straight forward and more powerful than a non-descriptive
debug
prop that is even part of the prod bundle.The uncontrolled case isn't as straight forward but you can always switch to controlled in your codebase