[core] Try out new JSX transform where available #22455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 2574143...925c5e3 |
As is tradition: |
This reverts commit ca76e87.
eps1lon
force-pushed
the
feat/jsx-runtime
branch
from
4131a13 to
925c5e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this is on track to become the default in Babel 8 we should try it out periodically. Since it's only available in React 17 we can use existing scripts. I extended running with
react@nextto our azure pipeline which is responsible for bundle size tracking.I'm mostly interested in the bundle size overhead due to effectively bundling two APIs for creating React elements.Since we also considerreactas external (effectively ignoring it in the bundle size output) we should apply toreact/jsx-runtime. Once we tree-shake the actualreactmodule (e.g.import { useMemo } from 'react'we should includereactandreact/jsx-runtime.Babel announcement