Menu has nested items support using popover #2148
Conversation
| anchorEl={this.state.anchorEl} | ||
| open={this.state.open} | ||
| onRequestClose={this._onRequestClose}> | ||
| <Menu desktop={desktop} disabled={disabled} style={{position:'relative'}}> |
There was a problem hiding this comment.
I think that we should move {position:'relative'} in a shared variable.
I think that we should add PureRenderMixin to the Menu component in the future.
This would prevent unnecessary rerender.
|
@chrismcv I have just made minor feedbacks. Nice work 👍. |
oliviertassinari
added
PR: needs revision
chrismcv
force-pushed
the
menu-nested
branch
from
1cdd14b
to
9379166
Compare
|
@oliviertassinari - bug fixed, and other changes made. Can squash if you like. |
|
@oliviertassinari - want a squash here? |
|
Let's take care of this issue first
I this something easy to fix? |
|
@oliviertassinari - how about now? I think we should hold off merging until it works. (I'm around today and tomorrow to resolve further if needs be) |
|
It's working now 👍. |
chrismcv
force-pushed
the
menu-nested
branch
from
892e00d
to
2b709f2
Compare
|
@oliviertassinari should be good now! (squashed too) |
|
Need a rebase and 🔥 |
chrismcv
force-pushed
the
menu-nested
branch
from
2b709f2
to
5effa88
Compare
|
😭 sorted I think |
chrismcv
force-pushed
the
menu-nested
branch
from
5effa88
to
b744d9b
Compare
|
@oliviertassinari - done |
|
@chrismcv Finally, I still see some weird stuff, but I think that it should be ok for a first iteration! |
[Menu] Add nested items support using popover
|
@oliviertassinari yeah - apologies that took so long! thanks 🎉 |
|
@chrismcv I can start working on enforcing new eslint rules 😉 |
Reworked from #1845.
This one might need some UX review.