-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Improve multi-realms support (remove instanceof HTMLElement) #20646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
nodeType
branch
from
April 19, 2020 15:53
ba2e683
to
df44a7c
Compare
eps1lon
approved these changes
Apr 19, 2020
joshwooding
approved these changes
Apr 19, 2020
Details of bundle changes.Comparing: 77f6fe0...2861516 Details of page changes
|
oliviertassinari
force-pushed
the
nodeType
branch
5 times, most recently
from
April 19, 2020 16:51
026998f
to
b852e92
Compare
oliviertassinari
force-pushed
the
nodeType
branch
from
April 19, 2020 16:54
b852e92
to
2861516
Compare
joshwooding
approved these changes
Apr 19, 2020
This was referenced Apr 29, 2020
This was referenced May 6, 2020
2 tasks
oliviertassinari
changed the title
[core] Avoid test with instanceof HTMLElement
[core] Improve multi-realms support (remove test with instanceof HTMLElement)
Dec 11, 2022
oliviertassinari
changed the title
[core] Improve multi-realms support (remove test with instanceof HTMLElement)
[core] Improve multi-realms support (remove instanceof HTMLElement)
Dec 11, 2022
oliviertassinari
added
bug 🐛
Something doesn't work
enhancement
This is not a bug, nor a new feature
and removed
enhancement
This is not a bug, nor a new feature
labels
Dec 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a follow-up on merceyz/typescript-to-proptypes#3.
instanceof
breaks down when you try to test an object coming from another realm. The ones that are created for each<iframe>
,<frame>
orpopup
window that you create. http://tobyho.com/2011/01/28/checking-types-in-javascript/https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/instanceof#instanceof_and_multiple_realms
These cases can be encountered when using:
The alternative is simple. The need for other realms can be very real, e.g. I assume https://www.openfin.co/ runs JavaScript in different realms.