Fix floating label being hidden #2029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -229,6 +229,7 @@ const TextField = React.createClass({ | |||
| top: 38, | |||
| bottom: 'none', | |||
| opacity: 1, | |||
| zIndex: 2, | |||
There was a problem hiding this comment.
Yea, anything above 0 works. I've changed it to 1 now
|
@EnzoMartin Could you give us a screenshot of the issue? |
oliviertassinari
added
PR: needs revision
|
Sure Before: After: |
|
@EnzoMartin Looks good to me 👍. I'm gonna just ask you to add a comment on the line to explain why this is here and to squash down the commit (to keep the history clean). |
|
Hit the wrong command in Git, sorry, made a new PR instead: #2078 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue with the floating label being hidden when the field is selected by Chrome to be autocompleted as it was rendered under Chrome's yellow background highlight of the field