TimePicker can be used as a controlled input (support value and valueLink props) #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
valueLink is going to be deprecated by facebook. I think that we shouldn't implement it. |
oliviertassinari
added
PR: needs revision
rscnt
added a commit
to rscnt/material-ui
that referenced
this pull request
Jan 29, 2016
If a TimePicker instance is already mounted and a new defaultTime is passed to it, the `time` state value doesn't update. There was already a pull request aiming to fix this and other issues for this component at mui#2027, but it has been waiting for review since Nov 24, 2015.
This was referenced Jan 29, 2016
|
@CameronFletcher92 I'm going to close this PR because we are moving towards removing |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Update `ref` to `inputRef` on the broken demo Fixes Issue mui#2027 * yarn prettier Co-authored-by: Dmitriy Kovalenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to add value/valueLink support to the TimePicker in an identical way to how the DatePicker handles things. Addresses issue #1710.