-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Mark toolbar for assistive technology #20158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
docs
Improvements or additions to the documentation
accessibility
a11y
labels
Mar 17, 2020
Details of bundle changes.Comparing: 10bc98f...a5b95b3 Details of page changes
|
eps1lon
force-pushed
the
docs/a11y-toolbar
branch
from
March 18, 2020 17:36
e755976
to
a5b95b3
Compare
oliviertassinari
approved these changes
Mar 18, 2020
EsoterikStare
pushed a commit
to EsoterikStare/material-ui
that referenced
this pull request
Mar 30, 2020
This was referenced Mar 30, 2020
This was referenced Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
toolbar
semantics for the group of elements that changes the demo source code. I was always a bit uncomfortable with thehideHeader
options. Since we have proper a11y semantics for it we should leverage it.Motivated by the desire to easily skip these elements from the a11y snapshot tests. Will do some tests with AT to see the impact.
Edit:
Did some tests and nvda+firefox and VoiceOver correctly identify it (adds a line that you're in the "demo source toolbar"). VoiceOver even implements arrow controls. This is a good first step. Eventually we'll remove all the buttons in it from tab order and manage focus via arrow keys (i.e. make an accessible ToolBar component) but that can be done later.