[Autocomplete] Zero (0) integer key display throws #18994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 50601ce...661a6d4
|
eps1lon
approved these changes
Dec 27, 2019
| @@ -233,7 +233,7 @@ export default function useAutocomplete(props) { | |||
| const open = isOpenControlled ? openProp : openState; | |||
|
|
|||
| const inputValueFilter = | |||
| !multiple && value && inputValue === getOptionLabel(value) ? '' : inputValue; | |||
There was a problem hiding this comment.
We should start linting against these. It's hidden loose equality checking and I think we had like 5-10 issues the last year concerning these. In a typed language this might be ok (if you know the type already is boolean). In a weakly typed language this is dangerous while not improving readability (I'd say it's even worse). The added bytes is negligible.
There was a problem hiding this comment.
I also remember a few occurrences of this type of bug. It's fascinating to see the length of which the components get battle-tested.
eps1lon
added
component: autocomplete
eps1lon
reviewed
Dec 27, 2019
| @@ -585,7 +587,7 @@ export default function useAutocomplete(props) { | |||
| inputRef.current.value.length, | |||
| ); | |||
| } | |||
| } else if (freeSolo && inputValueFilter !== '') { | |||
There was a problem hiding this comment.
Introduced in #18786.
The Enter key shouldn't trigger a new onChange event if its already currently selected.
For future reference: Prefer to codify this explicitly rather than communicating this implicitly with a type (here: the empty string). A variable if (inputValueIsSelectedValue === false) is more readable than if (inputValueFilter === '')
There was a problem hiding this comment.
Sounds fair, it will help our future self.
eps1lon
added
PR: ready to ship
and removed
PR: needs test
oliviertassinari
approved these changes
Dec 27, 2019
| @@ -585,7 +587,7 @@ export default function useAutocomplete(props) { | |||
| inputRef.current.value.length, | |||
| ); | |||
| } | |||
| } else if (freeSolo && inputValueFilter !== '') { | |||
There was a problem hiding this comment.
Sounds fair, it will help our future self.
This was referenced Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddressesFixes #18327.Happy to write some tests here but still getting familiar with the test suite.