Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Improve table of contents cmd+click #18765

Merged
merged 3 commits into from
Dec 10, 2019
Merged

[docs] Improve table of contents cmd+click #18765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
102fb2b
[Docs] fix item activation on cmd+click
Janpot Dec 9, 2019
f91eb27
do the ignore cmd+click method
Janpot Dec 9, 2019
5617f0f
go with react-router rather than next.js
oliviertassinari Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion docs/src/modules/components/AppTableOfContents.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,19 @@ export default function AppTableOfContents(props) {
// Corresponds to 10 frames at 60 Hz
useThrottledOnScroll(itemsServer.length > 0 ? findActiveIndex : null, 166);

const handleClick = hash => () => {
const handleClick = hash => event => {
// Ignore click for new tab/new window behavior
if (
event.defaultPrevented ||
event.button !== 0 || // ignore everything but left-click
event.metaKey ||
event.ctrlKey ||
event.altKey ||
event.shiftKey
) {
return;
}

// Used to disable findActiveIndex if the page scrolls due to a click
clickedRef.current = true;
unsetClickedRef.current = setTimeout(() => {
Expand Down
4 changes: 2 additions & 2 deletions docs/src/modules/components/MarkdownLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ export async function handleEvent(event, as) {
event.button !== 0 || // ignore everything but left-click
event.metaKey ||
event.ctrlKey ||
event.shiftKey ||
(event.nativeEvent && event.nativeEvent.which === 2)
event.altKey ||
event.shiftKey
) {
return;
}
Expand Down