-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Expand virtualized example to have grouped items #18763
Conversation
No bundle size changes comparing c4c5a03...62f22b6 |
This reverts commit 1b3e72c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to handle the height issue + the 8px padding on the top and bottom. Let me know what you think about it, I believe we are good :).
4df301f
to
4fb403d
Compare
👍 I guess that would work. What abut a constant to avoid the magic numbers? Like: const LISTBOX_PADDING = 8;
// ...
top: style.top + LISTBOX_PADDING
// ...
height={getHeight() + 2 * LISTBOX_PADDING} |
Sure 👍 |
Thank you |
Fixes #18597
I also tweaked the responsiveness a bit. There were some edge cases.