Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Expand virtualized example to have grouped items #18763

Merged
merged 9 commits into from
Dec 12, 2019

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Dec 9, 2019

Fixes #18597

I also tweaked the responsiveness a bit. There were some edge cases.

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 9, 2019

No bundle size changes comparing c4c5a03...62f22b6

Generated by 🚫 dangerJS against 62f22b6

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: autocomplete This is the name of the generic UI component, not the React module! labels Dec 9, 2019
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to handle the height issue + the 8px padding on the top and bottom. Let me know what you think about it, I believe we are good :).

@Janpot
Copy link
Member Author

Janpot commented Dec 10, 2019

👍 I guess that would work. What abut a constant to avoid the magic numbers? Like:

const LISTBOX_PADDING = 8;
// ...
top: style.top + LISTBOX_PADDING
// ...
height={getHeight() + 2 * LISTBOX_PADDING}

@oliviertassinari
Copy link
Member

Sure 👍

@oliviertassinari oliviertassinari merged commit a98c01c into mui:master Dec 12, 2019
@oliviertassinari
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Virtualized with grouped items
3 participants