Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] Fix PaperProps className merge conflict #18740

Merged

Conversation

siriwatknp
Copy link
Member

Closes: #18714

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 8, 2019

Details of bundle changes.

Comparing: 09e3a3c...84d2364

bundle Size Change Size Gzip Change Gzip
docs.main ▲ +30 B (0.00% ) 609 kB ▲ +13 B (+0.01% ) 194 kB
Drawer ▲ +30 B (+0.04% ) 83 kB ▲ +11 B (+0.04% ) 25.2 kB
SwipeableDrawer ▲ +30 B (+0.03% ) 90.4 kB ▲ +11 B (+0.04% ) 27.9 kB
@material-ui/core ▲ +30 B (+0.01% ) 355 kB ▲ +10 B (+0.01% ) 97.1 kB
@material-ui/core[umd] ▲ +30 B (+0.01% ) 312 kB ▼ -1 B (-0.00% ) 90.1 kB
@material-ui/lab -- 175 kB -- 52.4 kB
@material-ui/styles -- 50.8 kB -- 15.3 kB
@material-ui/system -- 14.5 kB -- 4.03 kB
AppBar -- 62.4 kB -- 19.5 kB
Autocomplete -- 127 kB -- 39.8 kB
Avatar -- 63.9 kB -- 20.1 kB
AvatarGroup -- 60.9 kB -- 19.1 kB
Backdrop -- 66.4 kB -- 20.5 kB
Badge -- 64 kB -- 19.8 kB
BottomNavigation -- 61.1 kB -- 19.1 kB
BottomNavigationAction -- 74.1 kB -- 23.4 kB
Box -- 69.4 kB -- 21 kB
Breadcrumbs -- 66.7 kB -- 20.8 kB
Button -- 78.1 kB -- 23.9 kB
ButtonBase -- 72.6 kB -- 22.7 kB
ButtonGroup -- 80.7 kB -- 24.8 kB
Card -- 61.4 kB -- 19.1 kB
CardActionArea -- 73.7 kB -- 23.1 kB
CardActions -- 60.7 kB -- 19 kB
CardContent -- 60.7 kB -- 18.9 kB
CardHeader -- 63.7 kB -- 20 kB
CardMedia -- 61 kB -- 19.1 kB
Checkbox -- 80.6 kB -- 25.4 kB
Chip -- 81.2 kB -- 24.8 kB
CircularProgress -- 62.8 kB -- 19.7 kB
ClickAwayListener -- 3.87 kB -- 1.56 kB
Collapse -- 66.6 kB -- 20.6 kB
colorManipulator -- 3.85 kB -- 1.52 kB
Container -- 61.9 kB -- 19.3 kB
CssBaseline -- 56.2 kB -- 17.6 kB
Dialog -- 81.3 kB -- 25.4 kB
DialogActions -- 60.8 kB -- 19 kB
DialogContent -- 60.9 kB -- 19 kB
DialogContentText -- 62.7 kB -- 19.7 kB
DialogTitle -- 63 kB -- 19.7 kB
Divider -- 61.3 kB -- 19.2 kB
docs.landing -- 52.4 kB -- 11.4 kB
ExpansionPanel -- 69.9 kB -- 21.8 kB
ExpansionPanelActions -- 60.8 kB -- 19 kB
ExpansionPanelDetails -- 60.6 kB -- 18.9 kB
ExpansionPanelSummary -- 76.7 kB -- 24.2 kB
Fab -- 75.4 kB -- 23.4 kB
Fade -- 22.2 kB -- 7.68 kB
FilledInput -- 72.1 kB -- 22.3 kB
FormControl -- 63.1 kB -- 19.6 kB
FormControlLabel -- 64.2 kB -- 20.1 kB
FormGroup -- 60.7 kB -- 19 kB
FormHelperText -- 61.9 kB -- 19.4 kB
FormLabel -- 62.1 kB -- 19.2 kB
Grid -- 63.8 kB -- 20 kB
GridList -- 61.2 kB -- 19.2 kB
GridListTile -- 62.4 kB -- 19.5 kB
GridListTileBar -- 61.9 kB -- 19.3 kB
Grow -- 22.8 kB -- 7.8 kB
Hidden -- 64.6 kB -- 20.2 kB
Icon -- 61.5 kB -- 19.2 kB
IconButton -- 74.8 kB -- 23.3 kB
Input -- 71.1 kB -- 22.1 kB
InputAdornment -- 63.8 kB -- 20 kB
InputBase -- 69.2 kB -- 21.6 kB
InputLabel -- 64 kB -- 19.9 kB
LinearProgress -- 64 kB -- 20 kB
Link -- 65.3 kB -- 20.5 kB
List -- 61 kB -- 19 kB
ListItem -- 75.7 kB -- 23.6 kB
ListItemAvatar -- 60.8 kB -- 19 kB
ListItemIcon -- 60.9 kB -- 19 kB
ListItemSecondaryAction -- 60.7 kB -- 19 kB
ListItemText -- 63.6 kB -- 19.9 kB
ListSubheader -- 61.4 kB -- 19.3 kB
Menu -- 86.9 kB -- 26.7 kB
MenuItem -- 76.8 kB -- 23.9 kB
MenuList -- 64.6 kB -- 20.2 kB
MobileStepper -- 66.4 kB -- 20.8 kB
Modal -- 14.3 kB -- 5 kB
NativeSelect -- 75.4 kB -- 23.7 kB
NoSsr -- 2.19 kB -- 1.03 kB
OutlinedInput -- 72.6 kB -- 22.5 kB
Paper -- 60.9 kB -- 18.9 kB
Popover -- 81.3 kB -- 25.1 kB
Popper -- 28.7 kB -- 10.2 kB
Portal -- 2.9 kB -- 1.3 kB
Radio -- 81.5 kB -- 25.6 kB
RadioGroup -- 61.9 kB -- 19.3 kB
Rating -- 68.7 kB -- 22 kB
RootRef -- 4.21 kB -- 1.64 kB
Select -- 113 kB -- 33.5 kB
Skeleton -- 61.2 kB -- 19.3 kB
Slide -- 24.3 kB -- 8.3 kB
Slider -- 74.3 kB -- 23.3 kB
Snackbar -- 75.8 kB -- 23.7 kB
SnackbarContent -- 64.3 kB -- 20.2 kB
SpeedDial -- 84.7 kB -- 26.7 kB
SpeedDialAction -- 116 kB -- 36.5 kB
SpeedDialIcon -- 63.2 kB -- 19.8 kB
Step -- 61.3 kB -- 19.2 kB
StepButton -- 80.9 kB -- 25.5 kB
StepConnector -- 61.4 kB -- 19.3 kB
StepContent -- 67.7 kB -- 21.1 kB
StepIcon -- 63.3 kB -- 19.7 kB
StepLabel -- 67.3 kB -- 21.1 kB
Stepper -- 63.4 kB -- 19.9 kB
styles/createMuiTheme -- 15.4 kB -- 5.44 kB
SvgIcon -- 61.7 kB -- 19.2 kB
Switch -- 79.8 kB -- 25 kB
Tab -- 75 kB -- 23.6 kB
Table -- 61.2 kB -- 19.2 kB
TableBody -- 60.8 kB -- 19 kB
TableCell -- 62.7 kB -- 19.7 kB
TableFooter -- 60.8 kB -- 19 kB
TableHead -- 60.8 kB -- 19 kB
TablePagination -- 139 kB -- 40.7 kB
TableRow -- 61.2 kB -- 19.1 kB
TableSortLabel -- 76 kB -- 23.8 kB
Tabs -- 84.1 kB -- 26.5 kB
TextareaAutosize -- 5.06 kB -- 2.11 kB
TextField -- 122 kB -- 35.5 kB
ToggleButton -- 74.8 kB -- 23.6 kB
ToggleButtonGroup -- 61.9 kB -- 19.4 kB
Toolbar -- 61 kB -- 19.1 kB
Tooltip -- 99.5 kB -- 31.4 kB
TreeItem -- 72.3 kB -- 22.8 kB
TreeView -- 65 kB -- 20.4 kB
Typography -- 62.3 kB -- 19.4 kB
useAutocomplete -- 12.3 kB -- 4.6 kB
useMediaQuery -- 2.47 kB -- 1.04 kB
Zoom -- 22.3 kB -- 7.68 kB

Generated by 🚫 dangerJS against 84d2364

@siriwatknp
Copy link
Member Author

@oliviertassinari how can I fix the test failed?

@merceyz
Copy link
Member

merceyz commented Dec 8, 2019

@siriwatknp Run yarn docs:api and commit the changes

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module! labels Dec 8, 2019
@oliviertassinari oliviertassinari changed the title fix: 🐛 able to add className to paper in drawer [Drawer] Fix PaperProps className merge conflict Dec 8, 2019
@oliviertassinari
Copy link
Member

@merceyz Thanks for the help!

@oliviertassinari
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: drawer This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Drawer] PaperProps className override base class
4 participants