-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Drawer] Fix PaperProps className merge conflict #18740
Merged
oliviertassinari
merged 2 commits into
mui:master
from
siriwatknp:#18714-drawer-paperprops-classname
Dec 9, 2019
Merged
[Drawer] Fix PaperProps className merge conflict #18740
oliviertassinari
merged 2 commits into
mui:master
from
siriwatknp:#18714-drawer-paperprops-classname
Dec 9, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundle changes.Comparing: 09e3a3c...84d2364
|
@oliviertassinari how can I fix the test failed? |
@siriwatknp Run |
oliviertassinari
added
bug 🐛
Something doesn't work
component: drawer
This is the name of the generic UI component, not the React module!
labels
Dec 8, 2019
oliviertassinari
changed the title
fix: 🐛 able to add className to paper in drawer
[Drawer] Fix PaperProps className merge conflict
Dec 8, 2019
@merceyz Thanks for the help! |
oliviertassinari
approved these changes
Dec 9, 2019
Thanks :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: drawer
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #18714