-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ClickAwayListener] Support other documents #18701
Merged
oliviertassinari
merged 1 commit into
mui:master
from
Izhaki:click-away-listener-support-other-documents
Dec 6, 2019
Merged
[ClickAwayListener] Support other documents #18701
oliviertassinari
merged 1 commit into
mui:master
from
Izhaki:click-away-listener-support-other-documents
Dec 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mouse and touch event were subscribing to `document`, meaning these were not intercepted within other documents, like an iframe. To support other documents, we now subscribe to node.ownerDocument.
@oliviertassinari I had no reproducible case to test this change. |
Details of bundle changes.Comparing: 8ba3283...717044d
|
oliviertassinari
approved these changes
Dec 5, 2019
Didn't fail locally on Chrome... I'll have a look tomorrow. |
Thanks, It seems that the test fail was a flaky timeout. |
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mouse and touch event were subscribing to
document
, meaning these were not intercepted within other documents, like an iframe.To support other documents, we now subscribe to node.ownerDocument.
Addresses a potential issue raise in #18689 / Pomax/react-onclickoutside#236.