Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[theme] Fix wrong ResponsiveFontSizesOptions type #18661

Merged
merged 1 commit into from
Dec 3, 2019
Merged

[theme] Fix wrong ResponsiveFontSizesOptions type #18661

merged 1 commit into from
Dec 3, 2019

Conversation

pstadler
Copy link
Contributor

@pstadler pstadler commented Dec 3, 2019

Before this fix, the following code would complain about variants not being compatible with ResponsiveFontSizesOptions, although this property must be passed as an array in any case:

responsiveFontSizes(theme, { factor: 1.5, breakpoints: ['sm'], variants: ['h1', 'h2'] })

Docs are correct: https://material-ui.com/customization/theming/#responsivefontsizes-theme-options-theme

@mui-pr-bot
Copy link

No bundle size changes comparing ea08d97...354a815

Generated by 🚫 dangerJS against 354a815

@oliviertassinari oliviertassinari changed the title Fix wrong type for ResponsiveFontSizesOptions.variants [theme] Fix wrong ResponsiveFontSizesOptions type Dec 3, 2019
@oliviertassinari oliviertassinari merged commit 2022b68 into mui:master Dec 3, 2019
@oliviertassinari
Copy link
Member

@pstadler Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants