[Autocomplete] Fix the errors reported by Wave #18283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
accessibility
Details of bundle changes.Comparing: 3d393bf...42aa823
|
|
|
||
| .token.boolean, | ||
| .token.number { | ||
| color: #b78eff; |
There was a problem hiding this comment.
Reach AA contrast level. The problem is more visible since the introduction of code previews.
| @@ -46,6 +46,7 @@ export default function Asynchronous() { | |||
|
|
|||
| return ( | |||
| <Autocomplete | |||
| id="asynchronous-demo" | |||
There was a problem hiding this comment.
Fix id duplication, server-side as reported by https://validator.w3.org/.
| @@ -310,6 +313,7 @@ const Autocomplete = React.forwardRef(function Autocomplete(props, ref) { | |||
| <IconButton | |||
| {...getPopupIndicatorProps()} | |||
| disabled={disabled} | |||
| aria-label={popupOpen ? 'Close popup' : 'Open popup'} | |||
There was a problem hiding this comment.
Fix a Wave error, not all the screen readers handle title.
| @@ -671,6 +671,7 @@ export default function useAutocomplete(props) { | |||
| }), | |||
| getInputLabelProps: () => ({ | |||
| id: `${id}-label`, | |||
| htmlFor: id, | |||
There was a problem hiding this comment.
In case somebody doesn't use our TextField.
| ref: inputRef, | ||
| autoCorrect: 'off', |
There was a problem hiding this comment.
Invalid HTML attribute and seems legacy for older versions of Safari. I'm eager to try without.
| 'aria-controls': `${id}-popup`, | ||
| // autoComplete: 'off', // Disable browser's suggestion that might overlap with the popup. | ||
| autoComplete: 'disabled', // disable autocomplete and autofill | ||
| 'aria-controls': popupOpen ? `${id}-popup` : null, |
There was a problem hiding this comment.
Fix https://validator.w3.org/ error were aria-controls points to a missing element.
| @@ -287,6 +288,7 @@ const Autocomplete = React.forwardRef(function Autocomplete(props, ref) { | |||
| > | |||
| {renderInput({ | |||
| ref: setAnchorEl, | |||
| id, | |||
There was a problem hiding this comment.
Used by TextField to link the helper text, input, and label together. Error reported by Wave and https://validator.w3.org/.
oliviertassinari
force-pushed
the
fix-wave-errors
branch
from
59ddd6b
to
42aa823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18132
Solve most of the errors reported by Wave and https://validator.w3.org/.