[Table] Improve RTL virtualized demo support #18038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing e09870b...d6f3278 |
mbrookes
added
the
component: table
oliviertassinari
changed the title
|
@FabianKielmann I don't understand this TypeScript fail, I have added a new commit with a different approach. |
|
@FabianKielmann Well done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't 100% sure about the changes in
ReactVirtualizedTable.jsbecause of the jsx one having the "declare module" part which I'm not familiar with. Also, I don't really know, what the "flip" property is actually used for but judging from your tsx diff, this should be fine.Closes #18029