Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Run tests periodically with react@next #18008

Merged
merged 9 commits into from
Oct 24, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 23, 2019

Runs test_unit, test_browser and test_regression once a day with reacts next release channel.

More info in https://reactjs.org/blog/2019/10/22/react-release-channels.html

Why we can't just yarn install react@next:

  1. In a monorepo it isn't trivial (with yarn v1) to bump a version
  2. enzyme's adapter has a dependency on react-test-renderer (which has a dependency on scheduler) and I'd rather not find out what happens if different versions are used.

Bonus:
This also allows running the pipeline with other release channels like experimental. This might be more interesting once CircleCI allows builds using their 2.1 config via API.

@oliviertassinari Could you change the required status checks accordingly?

-test_unit
+test_unit-1
-test_browser
+test_browser-1
-test_regression
+test_regression-1

@eps1lon eps1lon added the test label Oct 23, 2019
@mui-pr-bot
Copy link

No bundle size changes comparing 02ac04f...8dd3b49

Generated by 🚫 dangerJS against 8dd3b49

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it follows suite on vercel/next.js#9151 :)

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 23, 2019

How do we know if a build fails with a React canary version? Should we periodically remember to have a look at the build history?

@eps1lon
Copy link
Member Author

eps1lon commented Oct 24, 2019

I get mails for failed builds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants