-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Run tests periodically with react@next
#18008
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No bundle size changes comparing 02ac04f...8dd3b49 |
oliviertassinari
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it follows suite on vercel/next.js#9151 :)
How do we know if a build fails with a React canary version? Should we periodically remember to have a look at the build history? |
I get mails for failed builds |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs
test_unit
,test_browser
andtest_regression
once a day with reactsnext
release channel.More info in https://reactjs.org/blog/2019/10/22/react-release-channels.html
Why we can't just
yarn install react@next
:react-test-renderer
(which has a dependency onscheduler
) and I'd rather not find out what happens if different versions are used.Bonus:
This also allows running the pipeline with other release channels like
experimental
. This might be more interesting once CircleCI allows builds using their 2.1 config via API.@oliviertassinari Could you change the required status checks accordingly?