Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @material-ui/pickers from 3.2.5 to 3.2.7 #17886

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps @material-ui/pickers from 3.2.5 to 3.2.7.

Release notes

Sourced from @material-ui/pickers's releases.

v3.2.7

Hey, we are mostly started work on material-ui-pickers v4 🎉. We are going to significantly improve this package, but firstly we need to know how you are using pickers. Share your thoughts at our survey

Make sure

We are using some stuff from Typescript v3.4. So it is required to update

Fixes

This is a patch release with the following fixes:

  • Fix clock number position issue if overwrote theme spacing does not return a number as 1rem (#1327) @​bndynet
  • #1336 Do not crush if no enabled dates (#1343)
  • Update dependencies
  • [docs] Add some notifications to docs page
  • [docs] Fix not working moment example (#1353)

v3.2.6

Big thanks to 3 contributors, that make this release possible. 🥇

Features

  • Add new readOnly prop that prevents opening pickers
  • Move back to building with rollup, but save treeshaking @​TrySound (#1309)

Fixes

  • Fix typescript typings issue with new material-ui
  • Fix date picker header displaying issue with german locale
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@mui-pr-bot
Copy link

No bundle size changes comparing 83f5e19...8bd4abf

Generated by 🚫 dangerJS against 8bd4abf

@dmtrKovalenko
Copy link
Member

Make sure that @material-ui/pickers requires typescript version

@eps1lon
Copy link
Member

eps1lon commented Oct 15, 2019

I haven't put much thought into bumping typescript as I have no idea how this would be received. Do you have usage statistics on older typescript versions?

@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 19, 2019

  • I imagine it's a problem we are not the only ones to face. How are the other open-source projects handling the concern? For instance, Antd seems to upgrade it anytime dependabot proposes it.
  • I fail to understand. Why minor releases can cause problems?

@eps1lon
Copy link
Member

eps1lon commented Oct 20, 2019

I fail to understand. Why minor releases can cause problems?

typescript does not follow semantic versioning.

@oliviertassinari
Copy link
Member

Oh thanks, I had forgotten about microsoft/TypeScript#14116 (comment).

@dependabot-preview
Copy link
Contributor Author

Superseded by #18402.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/material-ui/pickers-3.2.7 branch November 17, 2019 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants