[Radio][Checkbox] Revert breaking changes #15483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
oliviertassinari
changed the title
oliviertassinari
changed the title
|
@material-ui/core: parsed: +0.29% , gzip: +0.06% Details of bundle changes.Comparing: 1155be4...f5ac6bf
|
oliviertassinari
force-pushed
the
radio-checkbox-revert
branch
from
66eec85 to
233cda3
Compare
oliviertassinari
changed the title
| - [Switch][Radio][Checkbox] Improve specification compliance. | ||
|
|
||
| Refactore the implementation to make it easier to override the styles. | ||
| - [Switch] Refactore the implementation to make it easier to override the styles. |
There was a problem hiding this comment.
I have reverted the specificity increase. You can see the impact on the customization examples. I believe the Radio and Checkbox changes are no longer breaking.
joshwooding
reviewed
Apr 25, 2019
joshwooding
reviewed
Apr 25, 2019
Co-Authored-By: oliviertassinari <[email protected]>
Co-Authored-By: oliviertassinari <[email protected]>
|
@joshwooding Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm reverting part of the changes done in #15097.
Closes #15470