[TextField] Fix height inconsistency #15217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gautam-pahuja
changed the title
|
Welcome to Material UI 🍰 Give me a treat 🌮 🎉 @gautam-relayr |
Details of bundle changes.Comparing: 4cfb8bd...61b43b4
|
|
@oliviertassinari I did the changes, updated the TS spec and ran prettier. It looks like the tests are still failing. Is it because Input inherits InputBase and I have to remove inputType from InputBase as well? Can you please help. Thanks 😄 |
oliviertassinari
changed the title
oliviertassinari
added
the
component: text field
|
The solution doesn't work, let's try something else.
|
oliviertassinari
approved these changes
Apr 6, 2019
eps1lon
reviewed
Apr 7, 2019
| @@ -85,8 +85,6 @@ export const styles = theme => { | |||
| inputMarginDense: {}, | |||
| /* Styles applied to the `input` element if `multiline={true}`. */ | |||
| inputMultiline: {}, | |||
| /* Styles applied to the `input` element if `type` is not "text"`. */ | |||
| inputType: {}, | |||
There was a problem hiding this comment.
We need to document this breaking change in the changelog.
|
Thanks @oliviertassinari and @eps1lon for all the help. |
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes committed fixes #15146
Breaking change.
Remove the
inputTypeclass.