[MenuList] Add home and end key support
#14212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least the rationale for this change wasn't explained.
oliviertassinari
added
component: menu
oliviertassinari
approved these changes
Jan 17, 2019
|
@oliviertassinari this change definitely works, the focus changes from the first ListItem on home and the last ListItem on end, but for whatever reason, the focus styles don't work without that extra bit of styling I inserted. So this technically works, but the user won't be able to see the first or last items being in focus. Would you like me to see if I can get it working without affecting any of the other styles? |
|
@dallin-christensen Oh right. I might have a fix. |
oliviertassinari
changed the title
home and end key support
| /* Styles applied to the `component`'s `focusVisibleClassName` property if `button={true}`. */ | ||
| focusVisible: { | ||
| backgroundColor: theme.palette.action.hover, |
There was a problem hiding this comment.
This style is almost 3 years old: 9a9ea7e.
There was a problem hiding this comment.
Gotcha. The changes look great! And all tests passing 👍
|
@dallin-christensen Well done |
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13865
MenuList now supports the use of home and end keys, changing focus to the first and last ListItem.