Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modal] Change keydown handling to use synthetic event #14134

Merged
merged 3 commits into from
Jan 14, 2019
Merged

[Modal] Change keydown handling to use synthetic event #14134

merged 3 commits into from
Jan 14, 2019

Conversation

rfbotto
Copy link
Contributor

@rfbotto rfbotto commented Jan 9, 2019

Closes #13470

@rfbotto rfbotto changed the title WIP: [Modal] Change keydown handling to use synthetic event [Modal] Change keydown handling to use synthetic event Jan 9, 2019
@mbrookes mbrookes added the component: modal This is the name of the generic UI component, not the React module! label Jan 11, 2019
@mbrookes
Copy link
Member

@rfbotto Thanks for working on this.

@oliviertassinari Was there a decision in the end regarding event.defaultPrevented, I couldn't quite tell from the discussion.

@oliviertassinari
Copy link
Member

@mbrookes I think that we should follow react-modal here:
https://github.com/reactjs/react-modal/blob/6a6bcf72aee2597b21a2b0b95dfd4a4efb77ce56/src/components/ModalPortal.js#L248-L249 @rfbotto it that OK with you? Do you want to update the implementation?

@oliviertassinari oliviertassinari added this to the v3.9.0 milestone Jan 11, 2019
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jan 11, 2019
@oliviertassinari oliviertassinari self-assigned this Jan 13, 2019
@oliviertassinari oliviertassinari force-pushed the add-on-key-down-to-modal branch from 8484f6f to 51cfaaa Compare January 13, 2019 11:28
oliviertassinari
oliviertassinari approved these changes Jan 13, 2019
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few comments and updated the test to pass. All green 🚀.

@oliviertassinari oliviertassinari removed their assignment Jan 13, 2019
@oliviertassinari oliviertassinari merged commit 69240e5 into mui:master Jan 14, 2019
@oliviertassinari
Copy link
Member

@rfbotto Well done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: modal This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
v3.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rfbotto @mbrookes @oliviertassinari