Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add support for changing react version in codesandbox demos #13686

Merged
merged 3 commits into from
Nov 26, 2018

Conversation

joshwooding
Copy link
Member

  • I have followed (at least) the PR section of the contributing guide.

  • [docs] Add support for changing react version in codesandbox demos

  • [docs] Change styles Hook API codesandbox to use next version of react and react-dom

Fixes #13680

Not sure if the demoOptions key should be react or reactVersion

@joshwooding joshwooding force-pushed the support-next-in-demos branch from 7c8f0e1 to 823555e Compare November 24, 2018 21:42
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 26, 2018
@oliviertassinari oliviertassinari merged commit f78ac87 into mui:master Nov 26, 2018
@oliviertassinari
Copy link
Member

@joshwooding Thank you :)

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 27, 2018

Not sure if the demoOptions key should be react or reactVersion

I went with the shortest version. It's also closer to what people have in their package.json.

@joshwooding joshwooding deleted the support-next-in-demos branch November 27, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants