Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grow] Condense the demo #13665

Merged
merged 2 commits into from
Nov 21, 2018
Merged

[Grow] Condense the demo #13665

merged 2 commits into from
Nov 21, 2018

Conversation

willigarneau
Copy link
Contributor

@willigarneau willigarneau commented Nov 21, 2018 •
edited
Loading

We could just use the component's timeout props. :)

@willigarneau
Timeout props
60c22a0 
We could just use the component's timeout props. Tried it myself and it worked :)
@willigarneau willigarneau changed the title Timeout props [Grow]Timeout props Nov 21, 2018
@oliviertassinari
Copy link
Member

conditionally applies the timeout property to change the entry speed.

@Thyix This changes the documentation description behavior. What's the motivation?

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: Grow labels Nov 21, 2018
@willigarneau
Copy link
Contributor Author

I was just using it, and wondered if you could use timeout props without adding a condition after the in props. After seeing that it worked, I thought it could be a nice fix for the future users :)

@oliviertassinari oliviertassinari changed the title [Grow]Timeout props [Grow] Condense the demo Nov 21, 2018
@oliviertassinari
Copy link
Member

@Thyix Ok thanks, your use case is valid but change what we want to demonstrate. I have added a comment in this pull request diff.

@oliviertassinari oliviertassinari merged commit 086a6a5 into mui:master Nov 21, 2018
mbrookes
mbrookes reviewed Nov 21, 2018
View reviewed changes
docs/src/pages/utils/transitions/SimpleGrow.js
@@ -39,27 +39,26 @@ class SimpleGrow extends React.Component {
const { classes } = this.props;
const { checked } = this.state;

const polygon = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps not the best choice of variable name...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

child?

@oliviertassinari oliviertassinari added component: transitions This is the name of the generic UI component, not the React module! and removed component: Grow labels Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mbrookes mbrookes mbrookes left review comments

Assignees
No one assigned
Labels
component: transitions This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willigarneau @oliviertassinari @mbrookes