[styles] Follow react docs for firstRender flag #13607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
the
package: styles
|
Let's wait the 100% test coverage before merging this pull request. I also want to see the peformance implication. |
We only need to change that value once. Every subsequent effect will be a noop anyways.
oliviertassinari
force-pushed
the
refactor/styles/cleanup-makestyles
branch
from
ba6fb2a to
3efbb48
Compare
oliviertassinari
approved these changes
Feb 19, 2019
oliviertassinari
added
new feature
eps1lon
commented
Feb 19, 2019
|
@eps1lon It looks more idiomatic than my setstate hack, well-spotted :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was something where the intention of the code was not apparent to me and looked like it was using
useStatenot for its intended purpose. Turns out the react docs already had this use case in mind: https://reactjs.org/docs/hooks-faq.html#can-i-run-an-effect-only-on-updates