Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] move babel/runtime to devDep #13220

Closed
wants to merge 1 commit into from
Closed

[icons] move babel/runtime to devDep #13220

wants to merge 1 commit into from

Conversation

eddiemonge
Copy link
Contributor

@babel/runtime does not look like it is needed to run package so it
should be a devDependency

`@babel/runtime` does not look like it is needed to run package so it
should be a devDependency
@mbrookes
Copy link
Member

var _interopRequireDefault = require("@babel/runtime/helpers/interopRequireDefault");

@eddiemonge
Copy link
Contributor Author

@mbrookes I don't see that in the code anywhere.

@eps1lon
Copy link
Member

eps1lon commented Oct 12, 2018

@eddiemonge We need it because we transpile our code with @babel/plugin-transform-runtime.

@eddiemonge
Copy link
Contributor Author

Ugh. That is so dirty. The babel runtime transform should be adding that code itself instead of requiring another package.

@eddiemonge eddiemonge closed this Oct 12, 2018
@eddiemonge eddiemonge deleted the patch-2 branch October 12, 2018 20:51
@eps1lon eps1lon mentioned this pull request Oct 13, 2018
@zannager zannager added the package: icons Specific to @mui/icons label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants